Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.9.5

Bug #11009 Zend code analyzer / issues with ChannelFile
Submitted: 2007-05-11 01:10 UTC Modified: 2007-05-19 18:46 UTC
From: doconnor Assigned: doconnor
Status: Closed Package: PEAR (version 1.5.4)
PHP Version: 5.2.1 OS:
Roadmaps: 1.6.0    
Subscription  


 [2007-05-11 01:10 UTC] doconnor (Daniel O'Connor)
Description: ------------ Assorted zend code analyzer issues exist, mostly from what looks like refactoring. This results in errors like: ChannelFile.php(line 714): Variable 'i' encountered only once. May be a typo? ChannelFile.php(line 714): Value assigned to variable 'i' is never used ChannelFile.php(line 1416): Variable 'found' encountered only once. May be a typo? ChannelFile.php(line 1416): Value assigned to variable 'found' is never used ChannelFile.php(line 287): Variable 'error' is used before it was assigned. ChannelFile.php(line 287): Variable 'error' encountered only once. May be a typo? ChannelFile.php(line 1020): Value assigned to variable 'server' is never used ChannelFile.php(line 1158): Variable 'setmirror' encountered only once. May be a typo? The attached patch addresses all raised ZCA issues. It needs some review, as it simply removes unused variables ($setmirror), and the like.

Comments

 [2007-05-19 18:46 UTC] cellog (Greg Beaver)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. a minority of the fixes are spurious, I've fixed the ones that actually matter (adding the () around stuff doesn't do anything but slow down parsing of the file)