Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.7.0

Bug #10971 Missing error check
Submitted: 2007-05-07 11:45 UTC Modified: 2007-06-17 00:15 UTC
From: lsolesen Assigned: timj
Status: Closed Package: PEAR_PackageFileManager (version 1.6.0)
PHP Version: 5.2.1 OS: Win
Roadmaps: 1.6.1    
Subscription  


 [2007-05-07 11:45 UTC] lsolesen (Lars Olesen)
Description: ------------ Just before 1750 in &_getExistingPackageXML(), there is a missing error check. If the following line produces an error, the script doesn't stop: $pf = &$pkg->parse($contents, $path . $packagefile, false, 'PEAR_PackageFileManager2'); I had an error because a developer had used a Danish character in a filename, and thus $pf contained a xml parsing error because of an invalid character.

Comments

 [2007-05-07 13:27 UTC] lsolesen (Lars Olesen)
By the way, it seems as if this method is called, and that the script is parsing an existing packagefile, even though the following code is used: $pfm = new PEAR_PackageFileManager2(); And not importing.
 [2007-06-17 00:15 UTC] cellog (Greg Beaver)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. Tim fixed this with his last commit