Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.26.0

Bug #10948 Unclosed tags in bug tracker
Submitted: 2007-05-06 04:49 UTC Modified: 2007-05-06 15:52 UTC
From: wiesemann Assigned: wiesemann
Status: Closed Package: pearweb (version 1.15.0)
PHP Version: 5.2.1 OS:
Roadmaps: 1.15.1    
Subscription  


 [2007-05-06 04:49 UTC] wiesemann (Mark Wiesemann)
Description: ------------ If a comment is not confirmed, two tags (<div>, <pre>) are not closed. Layout is broken then for comments that follow such an unconfirmed comment. The attached patch also fixed another notice in bug.php (was fixed in patch, but not committed).

Comments

 [2007-05-06 12:10 UTC] wiesemann (Mark Wiesemann)
I just saw that the bug preview layout is also broken (when logged in). The new patch also fixes this problem.
 [2007-05-06 15:50 UTC] cellog (Greg Beaver)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. the first part of your patch is unnecessary. The code is: if (isset($_POST['in']) && (!isset($_POST['preview']) && $ncomment || $previous != $current)) { if (!$errors) { if (!isset($buggie)) { mail_bug_updates($bug, $_POST['in'], $from, $ncomment, $edit, $id, $previous, $current); you would change it to if (isset($_POST['in']) && (!isset($_POST['preview']) && $ncomment || $previous != $current)) { if (!$errors) { if (!isset($buggie)) { mail_bug_updates($bug, (isset($_POST['in']) ? $_POST['in'] : array()), $from, $ncomment, $edit, $id, $previous, $current); but this code is never executed if $_POST['in'] is not set (and shouldn't be, I might add).
 [2007-05-06 15:52 UTC] wiesemann (Mark Wiesemann)
> the first part of your patch is unnecessary. Okay, fine, I hadn't analyzed this part again, but just saw the difference between CVS and my local version. With the (new) if-condition this looks good now.