Description: ------------ When the $bSendToBrowser option is enabled in Image::Barcode->draw(), PHP Notice messages are generated at each draw. A patch to fix this: --- Barcode.php 2007-04-02 11:25:26.000000000 -0400 +++ Barcode.new.php 2007-04-02 16:00:34.000000000 -0400 @@ -106,9 +106,8 @@ imagedestroy($img); break; } - } else { - return $img; - } + } + return $img; } } ?> Test script: --------------- <?php require_once('Image/Barcode.php'); $BarCodeObj = new Image_Barcode(); $BarCodeObj->draw(1234,'code128','gif'); ?> Expected result: ---------------- Barcode printed to browser without error messages. Actual result: -------------- Barcode is printed to browser, but a PHP Notice is printed to the error log: [Mon Apr 02 16:04:57 2007] [error] [client x.x.x.x] PHP Notice: Only variable references should be returned by reference in /usr/local/php/lib/php/Image/Barcode.php on line 112

Swapping this to a feature request to 'become e_strict compliant'

Added patch remove-reference-return.

Adrian, your patch breaks the package on PHP4. Remember that we have to keep backwards compatibility. The correct way would be to set $img to "null" in ifsendtobrowser and then return $img at the bottom of the method.

Added patch remove-reference-return.

I've attached a revised the patch that should work. I'll make sure to test any other future fixes against PHP4 as well.

Adam, that patch will not work, because you never return the image when it is needed. Did you really test it? I meant you should set $img to null when the image is being sent to the browser, not when it shall be returned.

Christian, Yes, I tested it. My patch does set $img to null when the image is being sent to the browser, and it does not when it is being returned.

This won't be fixed in this package - Image_Barcode2 however, sure.