Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.9.4

Request #10496 list with channel information
Submitted: 2007-03-25 11:49 UTC Modified: 2007-05-29 11:40 UTC
From: tias Assigned: tias
Status: Closed Package: PEAR (version 1.5.1)
PHP Version: Irrelevant OS:
Roadmaps: 1.6.0    
Subscription  


 [2007-03-25 11:49 UTC] tias (Tias Guns)
Description: ------------ Hello, The command 'list' does not return information about the channel from which it is. If one does a 'list' with allchannels=true then there is no way to know from which channel the packages received are. This obviously poses problems when one wishes to use this information in a frontend, to allow the user to install this package. Attached is a patch that fixes this. Note that the patch also removes the duplicated code in 'doListAll()'. Both now supply the same output. Greetings, Tias

Comments

 [2007-05-19 19:09 UTC] cellog (Greg Beaver)
would you instead implement this with a new additional option pear list --verbose and update the patch?
 [2007-05-28 15:54 UTC] tias (Tias Guns)
I've implemented the channel-aware output with the option '--channelinfo (-i)'. The attached patch is fully BC. Note that this patch requires the 'Command_channels_BC' patch from request #10495
 [2007-05-29 09:51 UTC] cellog (Greg Beaver)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. please check over the commit mail, I changed a lot of the code
 [2007-05-29 11:26 UTC] tias (Tias Guns)
I've seen the changes, the Push/PopErrorHandling is good. The other changes are more about 'rewriting' the information, then 'adapting' it. Are array_unshift() and the like slower or less good for some reason ? There is also a little bug: line 196 of Registry.php: the 'if' is switched, should be if (!$channelinfo) {
 [2007-05-29 11:40 UTC] cellog (Greg Beaver)
fixed the !$channelinfo, thanks the array_unshift(), although correct, is not quite as maintainable. The new ways are slightly clearer, which should make it easier for future devs to read. It's a cosmetic change, but I think an important one.