Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.1.2

Bug #10118 quit command doesn't disconnect the socket
Submitted: 2007-02-18 21:25 UTC Modified: 2007-08-10 10:11 UTC
From: ian at mywits-end dot co dot uk Assigned: amir
Status: Closed Package: Net_SmartIRC (version 1.0.0)
PHP Version: Irrelevant OS: Linux
Roadmaps: (Not assigned)    
Subscription  


 [2007-02-18 21:25 UTC] ian at mywits-end dot co dot uk (Ian Gibbons)
Description: ------------ There is a bug in Net/SmartIRC/irccommands.php that results in the 'quit' command not disconnecting the socket when it is used. Infact after sending the quit message, it doesn't do anything else, leaving your script hanging until you otherwise terminate it. I have created a patch which fixes this and may be applied with "patch -p0 < irccommands.php.patch". The raised priority ensures the quit message is sent before the socket is destroyed, at which point your script should terminate normally. The patch assumes your php/pear dir is /usr/share/php, which should be correct for most people. You may need to adjust accordingly if this is not so by editing the patch. Kind Regards, Ian Test script: --------------- Download patch from: http://www.mywits-end.co.uk/irccommands.php.patch Expected result: ---------------- Before patch applied, 'quit' sends the quit message but leaves a script hanging. After patch applied, 'quit' works as documented. Actual result: -------------- As expected :)

Comments

 [2007-08-10 10:11 UTC] amir (Amir Mohammad Saied)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.