Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.5.0

Bug #6769 ImageMap.php doesnot check for boolean false with strpos
Submitted: 2006-02-13 15:44 UTC
From: peter at jingo dot com Assigned: nosey
Status: Closed Package: Image_Canvas (version 0.2.4)
PHP Version: 5.1.0 OS: Red Hat
Roadmaps: (Not assigned)    
Subscription  
Comments Add Comment Add patch


Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know! Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem : 27 + 49 = ?

 
 [2006-02-13 15:44 UTC] peter at jingo dot com
Description: ------------ the function _addMapTag($shape, $coords, $params) contains a check for double quotes when generating the image map. The check (which returns true even if no double quotes are used) is: if (strpos($value, '"') >= 0) { $tags .= $key . '=\'' . $value . '\''; } else { $tags .= $key . '="' . $value . '"'; } Test script: --------------- the fix is: if (strpos($value, '"') === false) { $tags .= $key . '="' . $value . '"'; } else { $tags .= $key . '=\'' . $value . '\''; } Expected result: ---------------- <area shape="circle" coords="75,72,2" href="#test" target="_blank" alt="test" title="test">

Comments

 [2006-02-13 20:53 UTC] User who submitted this comment has not confirmed identity
If you submitted this note, check your email.If you do not have a message, click here to re-send
MANUAL CONFIRMATION IS NOT POSSIBLE.  Write a message to pear-dev@lists.php.net
to request the confirmation link.  All bugs/comments/patches associated with this

email address will be deleted within 48 hours if the account request is not confirmed!