| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 0.21.8 |
| Bug #6729 | Veteran's Day wrong | ||
|---|---|---|---|
| Submitted: | 2006-02-08 16:58 UTC | ||
| From: | seth at pricepages dot org | Assigned: | luckec |
| Status: | Closed | Package: | Date_Holidays (version 0.15.1) |
| PHP Version: | Irrelevant | OS: | Mac |
| Roadmaps: | (Not assigned) | ||
[2006-02-08 16:58 UTC] seth at pricepages dot org
Description:
------------
Veteran's day is marked incorrectly in the calendar. It
looks like the code was copy-pasted, but someone forgot to
change most of it.
Here are the lines for Veteran's Day in Date/Holidays/
Driver/USA.php:
$columbusDay = $this->_calcNthMondayInMonth(11,2);
$this->_addHoliday('veteransDay',$columbusDay,'Veteran\'s
Day');
(Which looks suspiciously like Columbus Day...)
Veteran's Day should be the 11th day in November.
While I'm here, I'll mention that the Christmas Day variable
is $tday, which is a little odd... Maybe $cday would be more
appropriate, but no harm done.
Comments
[2006-02-11 22:42 UTC] User who submitted this comment has not confirmed identity
If you submitted this note, check your email.If you do not have a message, click here to re-send MANUAL CONFIRMATION IS NOT POSSIBLE. Write a message to pear-dev@lists.php.net to request the confirmation link. All bugs/comments/patches associated with this email address will be deleted within 48 hours if the account request is not confirmed!
[2006-02-13 02:25 UTC] seth at pricepages dot org
Veteran's Day should be the 11th day in Nov, but you have it
placed at the 2nd monday at Nov.
http://en.wikipedia.org/wiki/Veterans_Day
[2006-04-01 17:20 UTC] User who submitted this comment has not confirmed identity
If you submitted this note, check your email.If you do not have a message, click here to re-send MANUAL CONFIRMATION IS NOT POSSIBLE. Write a message to pear-dev@lists.php.net to request the confirmation link. All bugs/comments/patches associated with this email address will be deleted within 48 hours if the account request is not confirmed!