| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 0.5.2 |
| Bug #14937 | Make use of protected, not private | ||
|---|---|---|---|
| Submitted: | 2008-11-01 17:18 UTC | ||
| From: | doconnor | Assigned: | doconnor |
| Status: | Closed | Package: | MP3_Playlist (version CVS) |
| PHP Version: | 5.2.6 | OS: | |
| Roadmaps: | (Not assigned) | ||
[2008-11-01 17:18 UTC] doconnor
(Daniel O'Connor)
Description:
------------
Playlist has a bunch of private members variables and functions.
PHPCS says 'private methods/vars need an underscore'; and if you try to extend the class, you can't get access to all of the good bits.
Consider swapping these to protected, and renaming the private vars/methods appropriately.
Comments
[2008-12-28 00:06 UTC] doconnor
(Daniel O'Connor)
This bug has been fixed in CVS.
If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET).
If this was a problem with the pear.php.net website, the change should be live shortly.
Otherwise, the fix will appear in the package's next release.
Thank you for the report and for helping us make PEAR better.