Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 3.7.2

Bug #12476 PHP4 destructors are reported as error
Submitted: 2007-11-18 22:31 UTC
From: till Assigned: squiz
Status: Closed Package: PHP_CodeSniffer (version 1.0.0RC2)
PHP Version: 5.2.4 OS: FreeBSD
Roadmaps: 1.0.0RC3    
Subscription  


 [2007-11-18 22:31 UTC] till (Till Klampaeckel)
Description: ------------ FILE: ...l/public_html/pear.cvs/pear/Contact_Vcard_Parse/Contact/Vcard/Parse.php -------------------------------------------------------------------------------- FOUND 1 ERROR(S) AND 0 WARNING(S) AFFECTING 1 LINE(S) -------------------------------------------------------------------------------- 272 | ERROR | Method name "Contact_Vcard_Parse::_Contact_Vcard_Parse" is not in | | camel caps format -------------------------------------------------------------------------------- (I am checking in this file soon if you want to test it, shoot me an email or let me know on IRC. I'd like to be 100%-cweiske ^H^H^H^PHPCS compliant. :-))

Comments

 [2007-11-19 03:30 UTC] squiz (Greg Sherwood)
I stupidly removed the code that allowed PHP4 destructors to be ignored in a brain explosion a few versions ago. I'm adding some tests now so I don't forget in the future, and adding the code back in again.
 [2007-11-19 03:39 UTC] squiz (Greg Sherwood)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.
 [2007-11-19 05:49 UTC] till (Till Klampaeckel)
Thanks for the fast turn around. :)